[PATCH] erofs-utils: lib: fix QPL job leak on early error paths in z_erofs_decompress_qpl() After z_erofs_qpl_get_job() succeeds, two early-return error paths bypass z_erofs_qpl_put_job(), leaking the QPL job handle: - Line 200: return -EFSCORRUPTED (when inputmargin >= inputsize) - Line 205: return -ENOMEM (when malloc fails for decodedskip buffer) Fix by replacing the bare returns with goto out_inflate_end, which already handles both z_erofs_qpl_put_job() and free(buff).

[Gao Xiang]

On 2026/3/20 09:37, Gao Xiang wrote:
> 
> 
> On 2026/3/20 09:16, Ajay Rajera wrote:
>> Hi Vi-shub,
>> just a review :
>> I think the fix looks correct and it is the right approach but the
>> commit message formatting needs work. The entire description is in the
>> subject line. Per kernel conventions, the subject should be a short
>> one-liner, e.g: erofs-utils: lib: fix QPL job leak on early error
>> paths
>> The detailed explanation (which error paths leak, why, and how the fix
>> works) should go in the commit message body, separated from the
>> subject.
>>
>> So you can resend with the subject/body split fixed? so It will look more clear.
> 
> yes, the commit message is in a mess.

BTW, I don't know who is using the email address
<yifan at pku.edu.cn>, and the recipient doesn't exist.

Here, I want to say, I have to identfy you as another
AI bot.

Thanks,
Gao Xiang

> 
> Thanks,
> Gao Xiang
> 
>> Thanks, Ajay
>