[PATCH] erofs-utils: fuse: fix the clerical error in ASSERT

Gao Xiang hsiangkao at aol.com
Mon Oct 19 17:53:08 AEDT 2020


On Mon, Oct 19, 2020 at 12:49:21PM +0800, Huang Jianan wrote:
> Signed-off-by: Huang Jianan <huangjianan at oppo.com>
> ---
>  fuse/read.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fuse/read.c b/fuse/read.c
> index fd70a2a..e2f967a 100644
> --- a/fuse/read.c
> +++ b/fuse/read.c
> @@ -120,7 +120,7 @@ size_t erofs_read_data_compression(struct erofs_vnode *vnode, char *buffer,
>  			length = end - map.m_la;
>  			partial = true;
>  		} else {
> -			ASSERT(end == map.m_la + map_m_llen);
> +			ASSERT(end == map.m_la + map.m_llen);
>  			length = map.m_llen;
>  			partial = !(map.m_flags & EROFS_MAP_FULL_MAPPED);
>  		}
> -- 
> 2.25.1
> 

Reviewed-by: Gao Xiang <hsiangkao at aol.com>

Thanks, I will fold this in to the original patch.

btw, if we merge the erofsfuse codebase to the master branch
eventually, the following matters should be be done in advance
(if you have some extra time or interest):
 - get rid of customized error reporting, use erofs_xxx instead;
 - get rid of erofs_vnode, ..., use erofs_inode instead;
 - further clean up.

and I will keep working on this as well.

Thanks,
Gao Xiang



More information about the Linux-erofs mailing list