[PATCH v2 0/2] Add device tree for ASRock Rack ALTRAD8 BMC

[Andrew Jeffery]

Hi Rebecca,

On Mon, 2025-09-22 at 14:47 -0600, Rebecca Cran wrote:
> On 9/21/25 20:40, Andrew Jeffery wrote:
> 
> > On Wed, 2025-09-17 at 12:04 -0600, Rebecca Cran wrote:
> > > aspeed-bmc-asrock-altrad8.dts:578.16-581.6: Warning (unique_unit_address_if_enabled): /ahb/spi at 1e630000/flash at 0/partitions/code at 400000: duplicate unit-address (also used in node /ahb/spi at 1e630000/flash at 0/partitions/tfa at 400000)
> > It seems odd that the partitions intersect. Are the offsets correct? If
> > they are, can you add comments to the DTS discussing what's going on
> > there?
> I'll delete the code partition. I added it to make it easier for my 
> script to flash both TF-A and UEFI areas at once.

Okay, thanks.

> > 
> > > aspeed-bmc-asrock-altrad8.dtb: gpio at 1c (nxp,pca9557): '#address-cells', '#size-cells', 'gpio at 0', 'gpio at 1', 'gpio at 2', 'gpio at 3', 'gpio at 4', 'gpio at 5', 'gpio at 6', 'gpio at 7' do not match any of the regexes: '^(hog-[0-9]+|.+-hog(-[0-9]+)?)$', '^pinctrl-[0-9]+$'
> > > 	from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.yaml#
> > This one needs fixing.
> 
> I'm confused, because in the existing device tree files I'm only seeing 
> 'hog' used in the &gpio node, while 'pca[0-9]+' is commonly used as the 
> node names for pca95xx devices.

The error above is referring to properties and sub-nodes of your
nxp,pca9557 compatible node, rather than the name of the node itself.
That said, node names are preferred to be generic (e.g. gpio@) rather
than specific.

> 
> Does the gpio-pca95xx.yaml file need to be updated?
> 

It depends on what you're trying to achieve. At v6.17-rc1 no other
devicetree in the kernel defines an nxp,pca9557 node as you have here
with gpio@ subnodes, and neither does the gpio-pca95xx.yaml binding
allow them. What caused you to add them?

I expect what you need to do is remove those sub-nodes, along with
#address-cells and #size-cells.

Andrew