[PATCH v5 03/10] dt-bindings: gpio: ast2400-gpio: Add hogs parsing

[Ninad Palsule]

Hello Rob,

Thanks for the review.

On 1/15/25 08:24, Rob Herring wrote:
> On Wed, Jan 15, 2025 at 09:45:50AM +0100, Krzysztof Kozlowski wrote:
>> On Tue, Jan 14, 2025 at 04:01:37PM -0600, Ninad Palsule wrote:
>>> Allow parsing GPIO controller children nodes with GPIO hogs.
>>>
>>> Signed-off-by: Ninad Palsule<ninad at linux.ibm.com>
>>> ---
>>>   .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml       | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
>>> index b9afd07a9d24..b9bc4fe4d5a6 100644
>>> --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
>>> +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
>>> @@ -46,6 +46,12 @@ properties:
>>>       minimum: 12
>>>       maximum: 232
>>>   
>>> +patternProperties:
>>> +  "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
>> Choose one - suffix or prefix. More popular is suffix.
> I was about to say that, but this matches what gpio-hog.yaml defines.
> Why we did both, I don't remember. We could probably eliminate
> 'hog-[0-9]+' as that doesn't appear to be used much.
>
> Long term, I want to make all gpio controllers reference a gpio
> controller schema and put the hog stuff there. Then we have the node
> names defined in 1 place.

Which one of the following are you suggesting?

"^(.+-hog(-[0-9]+)?)$"
"^(pin-hog(-[0-9]+)?)$" any other? Regards, Ninad

>
> Rob
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20250115/fe84897c/attachment.htm>