<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello Rob,</p>
<p>Thanks for the review.<br>
</p>
<div class="moz-cite-prefix">On 1/15/25 08:24, Rob Herring wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20250115142457.GA3859772-robh@kernel.org">
<pre wrap="" class="moz-quote-pre">On Wed, Jan 15, 2025 at 09:45:50AM +0100, Krzysztof Kozlowski wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">On Tue, Jan 14, 2025 at 04:01:37PM -0600, Ninad Palsule wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Allow parsing GPIO controller children nodes with GPIO hogs.
Signed-off-by: Ninad Palsule <a class="moz-txt-link-rfc2396E" href="mailto:ninad@linux.ibm.com"><ninad@linux.ibm.com></a>
---
.../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
index b9afd07a9d24..b9bc4fe4d5a6 100644
--- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml
@@ -46,6 +46,12 @@ properties:
minimum: 12
maximum: 232
+patternProperties:
+ "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Choose one - suffix or prefix. More popular is suffix.
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
I was about to say that, but this matches what gpio-hog.yaml defines.
Why we did both, I don't remember. We could probably eliminate
'hog-[0-9]+' as that doesn't appear to be used much.
Long term, I want to make all gpio controllers reference a gpio
controller schema and put the hog stuff there. Then we have the node
names defined in 1 place.</pre>
</blockquote>
<p>Which one of the following are you suggesting?</p>
<pre wrap="" class="moz-quote-pre">"^(.+-hog(-[0-9]+)?)$"
"^(pin-hog<span style="white-space: pre-wrap">(-[0-9]+)?)$"
any other?
Regards,
Ninad
</span></pre>
<blockquote type="cite"
cite="mid:20250115142457.GA3859772-robh@kernel.org">
<pre wrap="" class="moz-quote-pre">
Rob
</pre>
</blockquote>
</body>
</html>