[PATCH v4] usb: gadget: aspeed_udc: validate endpoint index for ast udc
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Wed Jun 26 01:25:05 AEST 2024
On Tue, Jun 25, 2024 at 05:20:07PM +0200, Markus Elfring wrote:
> >>>>> We should verify the bound of the array to assure that host
> >>>>> may not manipulate the index to point past endpoint array.
> >>>>
> >>>> Why did you not choose an imperative wording for your change description?
> >>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc5#n94
> >>>
> >>> Markus, please stop reviewing USB patches. This is not helpful at all,
> >>> and causes new developers extra work for no reason at all.
> >>
> >> How does this feedback fit to the linked information source?
> >
> > That is not what I wrote.
>
> You indicated concerns according to patch review processes,
> didn't you?
>
> See also:
> * Patch submission notes
> https://elixir.bootlin.com/linux/v6.10-rc5/source/Documentation/process/maintainer-tip.rst#L100
This is not the tip tree.
> * Contributor Covenant Code of Conduct
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/code-of-conduct.rst?h=v6.10-rc5#n3
I do not see how this is relevant here.
> > I wrote, "Please stop reviewing USB patches."
> >
> > Please stop now.
>
> I might be going to influence evolution of this software area in other ways
> under other circumstances.
Please take some time and find other projects to help out.
greg k-h
More information about the Linux-aspeed
mailing list