[PATCH v3 3/3] i3c: ast2600: Add AST2600 platform-specific driver

[Jeremy Kerr]

Hi Lukwinski,

> > +	case 545:
> > +		reg = AST2600_I3CG_REG0_SDA_PULLUP_EN_2K |
> > +			AST2600_I3CG_REG0_SDA_PULLUP_EN_750;
>
> It does not work. To enable PullUp=545R you need to set both 28 and
> 29 bit (0x30000000) but 'AST2600_I3CG_REG0_SDA_PULLUP_EN_2K |
> AST2600_I3CG_REG0_SDA_PULLUP_EN_750' is in fact 0x20000000.

Ah, good catch - I'd missed that the 2K is 0b00.

> Maybe you could consider adding extra macro
> 'AST2600_I3CG_REG0_SDA_PULLUP_EN_545' = (0x3 << 28)?

Sounds good, I'll send a fix today.

Cheers,


Jeremy