vga_pw sysfs file

Joel Stanley joel at jms.id.au
Wed Nov 17 12:04:31 AEDT 2021


On Wed, 17 Nov 2021 at 00:59, Oskar Senft <osk at google.com> wrote:
>
> Hi Joel
>
> > > In uart_render_controller, however, we're checking whether the bottom
> > > 8 bit equal to 0xa8 (why are we not checking for != 0 here?)
> >
> > I think you found a mistake in the new sysfs file. I can't recall why
> > I masked the value the way I did.
>
> Ha, and I thought I'd have to argue my case ;-)
>
> > Thanks for investigating this. I'll send a patch to the kernel and if
> > you could test it that would be appreciated.
>
> Absolutely. I assume this will just be a 1-liner. I have the system
> setup and can test at any time.

Here we go:

 https://lore.kernel.org/all/20211117010145.297253-1-joel@jms.id.au/

Thanks for the detailed bug report. Please reply to that mail with
your tested-by once you've confirmed this works.

Cheers,

Joel


More information about the Linux-aspeed mailing list