vga_pw sysfs file

Oskar Senft osk at
Wed Nov 17 11:59:28 AEDT 2021

Hi Joel

> > In uart_render_controller, however, we're checking whether the bottom
> > 8 bit equal to 0xa8 (why are we not checking for != 0 here?)
> I think you found a mistake in the new sysfs file. I can't recall why
> I masked the value the way I did.

Ha, and I thought I'd have to argue my case ;-)

> Thanks for investigating this. I'll send a patch to the kernel and if
> you could test it that would be appreciated.

Absolutely. I assume this will just be a 1-liner. I have the system
setup and can test at any time.

Alternatively, I'd also be happy to send it through.


More information about the Linux-aspeed mailing list