[v2 2/8] dt-bindings: iio: adc: Binding ast2600 adc.
billy_tsai at aspeedtech.com
Mon Jul 26 17:21:29 AEST 2021
Thanks for your review. I will fix them.
About the vref I reply inline.
On 2021/7/23, 10:52 PM, "Jonathan Cameron" <Jonathan.Cameron at Huawei.com> wrote:
On Fri, 23 Jul 2021 16:16:15 +0800
Billy Tsai <billy_tsai at aspeedtech.com> wrote:
> > + • Internal or External reference voltage.
> > + • Support 2 Internal reference voltage 1.2v or 2.5v.
> > + • Integrate dividing circuit for battery sensing.
> > properties:
> > compatible:
> > enum:
> > - aspeed,ast2400-adc
> > - aspeed,ast2500-adc
> > + - aspeed,ast2600-adc
> > reg:
> > maxItems: 1
> > @@ -33,6 +45,18 @@ properties:
> > "#io-channel-cells":
> > const: 1
> > + vref:
> > + minItems: 900
> > + maxItems: 2700
> > + default: 2500
> > + description:
> > + ADC Reference voltage in millivolts.
> I'm not clear from this description. Is this describing an externally
> connected voltage reference? If so it needs to be done as a regulator.
> If it's a classic high precision reference, the dts can just use
> a fixed regulator.
In the ast2600, the ADC supports two internal reference voltages of 1.2v or 2.5v,
as well as external voltages. When the user selects a voltage of 1.2v or 2.5v, my
driver will first select to use the internal voltage.
As you mention at patch #4, you suggest to use two property to handle this feature.
vref: indicate the regulator handler. Like other dt-bindings used.
aspeed,int_vref_mv: indicate the chosen of 1.2v or 2.5v
and use "model_data->vref_fixed" to exclude ast2400 and ast2500
Is it right?
> > +
> > + battery-sensing:
> > + type: boolean
> > + description:
> > + Inform the driver that last channel will be used to sensor battery.
> This isn't (I think?) a standard dt binding, so it needs a manufacturer
More information about the Linux-aspeed