[RFC PATCH 4/6] leds: pca955x: Use pinctrl to map GPIOs to pins

Linus Walleij linus.walleij at linaro.org
Tue Aug 10 23:54:11 AEST 2021


On Fri, Jul 23, 2021 at 9:59 AM Andrew Jeffery <andrew at aj.id.au> wrote:

> The leds-pca955x driver currently assumes that the GPIO numberspace and
> the pin numberspace are the same. This quickly falls apart with a
> devicetree binding such as the following:
(...)

Honestly I do not understand this patch. It seems to implement a pin
controller and using it in nonstandard ways.

If something implements the pin controller driver API it should be
used as such IMO, externally. This seems to be using it do relay
calls to itself which seems complicated, just invent something
locally in the driver in that case? No need to use pin control?

Can you explain why this LED driver needs to implement a pin
controller?

Yours,
Linus Walleij


More information about the Linux-aspeed mailing list