[PATCH v2 2/3] dt-bindings: serial: 8250: Add documentation for espi-enabled.
osk at google.com
Fri Sep 6 00:41:13 AEST 2019
Hi Andrew and Jeremy
Thanks for both your input, that was helpful. I'm sorry it took me so long
to get back to this. I hope it's in better shape now.
> Given it's ASPEED-specific I expect you should use a vendor prefix for the
> > property, e.g. aspeed,espi-enabled.
That was a very good point.
> > However, as I understand it you want to determine what polarity the SIRQ
> > should be regardless of which of eSPI or LPC are enabled, so I don't
> > the property name should be an explicit statement about eSPI. Maybe
> > "aspeed,sirq-polarity-sense"?
> Yep, +1 on Andrew's comments here. This property isn't an indication on
> whether espi is enabled, but a method to detect it.
I agree. I was so focused on functionality that I didn't look at this with
a wider view.
I'll send v3 of the patch that contains appropriate changes. I'll also
include further lists and individuals to get OKs as needed.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Linux-aspeed