[PATCH] drivers/misc: Aspeed LPC snoop output using misc chardev

Benjamin Fair benjaminfair at google.com
Wed Jul 11 04:11:55 AEST 2018

On Mon, Jul 9, 2018 at 12:52 AM Greg Kroah-Hartman
<gregkh at linuxfoundation.org> wrote:
> On Fri, Jul 06, 2018 at 11:25:32AM -0700, Benjamin Fair wrote:
> > From: Robert Lippert <rlippert at google.com>
> >
> > Provides the data bytes snooped over the LPC snoop bus to userspace
> > as a (blocking) misc character device.
> If this is a debugging thing, why not just use debugfs instead of a char
> device?  That should make this code simpler overall, and you can do
> whatever you want with debugfs.
> thanks,
> greg k-h

This interface will primarily be used by a userspace daemon which will poll the
file for changes. The debugging usage in the commit message is for verifying
that the driver is working properly.

I'll update the commit message to make this more clear.


More information about the Linux-aspeed mailing list