[Lguest] [PATCH 2.6.23] lguest: LCA08 lguest tutorial - patch for Ctrl-Z suspend support (S-lzzz)

[Rusty Russell]

On Thursday 31 January 2008 12:42:10 Mark Wallis wrote:
> Support in the lguest userpace utility for triple-Ctrl-Z. Three fast
> taps of Ctrl-Z will suspend the lguest VM.
>
> Signed-off-by: Mark Wallis <lguest at markwallis.id.au>

Hi Mark,

   Sorry for the delayed reply.  I promised myself I would read through all 
the tutorial patches and give feedback; both for you and anyone else reading 
the list.

> @@ -706,6 +712,7 @@
>   	unsigned int num;
>   	struct iovec iov[LGUEST_MAX_DMA_SECTIONS];
>   	struct console_abort *abort = dev->priv;
> +	struct console_suspend *suspend = dev->priv;

This won't quite work: dev->priv cannot point to both structures!  You'll 
actually need to share structures with the abort code somehow.

The rest of your logic looks right though, and there are no style issues I can 
see.

Thanks!
Rusty.