[PATCH 1/3] misc: Add crossbar driver
Joe Perches
joe at perches.com
Fri Jul 19 02:55:18 EST 2013
On Thu, 2013-07-18 at 22:13 +0530, Sricharan R wrote:
> Some socs have a large number of interrupts/dma requests to service
> the needs of its many peripherals and subsystems. All of the
> requests lines from the subsystems are not needed at the same
> time, so they have to be muxed to the controllers appropriately.
> In such places a interrupt/dma controllers are preceded by an
> IRQ/DMA CROSSBAR that provides flexibility in muxing the device
> requests to the controller inputs.
[]
> diff --git a/drivers/misc/crossbar.c b/drivers/misc/crossbar.c
[]
> +int crossbar_unmap(struct device_node *cbdev_node, unsigned index)
[]
> + list_for_each_entry(cbdev, &cb_devlist, node) {
> + if (strcmp(cbdev->name, tmp.cb_name))
> + continue;
[]
> + dev_warn(cbdev->dev,
> + "unmapped int_no %x mapped to cb %x\n",
> + tmp.int_no, tmp.cb_no);
> + return 0;
[]
> + dev_warn(cbdev->dev, "%s cb entry %d not found\n",
> + __func__, tmp.cb_no);
> + return -ENOENT;
Why does this function always emit a dev_warn
before return? Maybe the first should be dev_info?
More information about the devicetree-discuss
mailing list