[PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt
Peter Korsgaard
jacmet at sunsite.dk
Mon Jul 15 15:31:18 EST 2013
>>>>> "Mark" == Mark Jackson <mpfj-list at newflow.co.uk> writes:
Hi,
Mark> On 08/07/13 13:42, Mark Jackson wrote:
>> On 18/01/13 05:14, Mugunthan V N wrote:
>>> On 1/18/2013 3:48 AM, Peter Korsgaard wrote:
>>>> When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old
>>>> U-Boot, not wanting the hassle of 2 files or when using Falcon fast boot
>>>> mode in U-Boot), nothing updates the ethernet hwaddr specified for the
>>>> CPSW slaves, causing the driver to use a random hwaddr, which is some times
>>>> troublesome.
>>>>
>>>> The am33xx has unique ethernet hwaddrs programmed in the efuse, so it makes
>>>> more sense to default to these rather than random ones. Add a fixup step
>>>> which adds mac-address dt properties using the efuse addresses if the DTB
>>>> didn't contain valid ones.
>>>>
>>>> Signed-off-by: Peter Korsgaard <jacmet at sunsite.dk>
>>>
>>> This implementation looks fine.
>>> Acked-by: Mugunthan V N <mugunthanvnm at ti.com>
>>
>> Tested-by: Mark Jackson <mpfj-list at newflow.co.uk>
Mark> Is this ever going to be put into the mainline code ?
Good question. Tony, could you please pick this up? It has been pending
since January and has a number of acks.
Do you want me to resend?
--
Bye, Peter Korsgaard
More information about the devicetree-discuss
mailing list