[PATCH v2 1/3] mmc: omap_hsmmc: Enable SDIO IRQ using a GPIO in idle mode.

[Felipe Balbi]

Hi,

On Fri, Apr 12, 2013 at 02:38:25PM +0200, Andreas Fenkart wrote:
> Without functional clock the omap_hsmmc module can't forward
> SDIO IRQs to the system. This patch reconfigures dat1 line as a
> gpio while the fclk is off. It uses regulare SDIO IRQ detection of
> the module, while fclk is present.
> 
> Reviewed-by: Grant Likely <grant.likely at secretlab.ca>
> Signed-off-by: Andreas Fenkart <andreas.fenkart at streamunlimited.com>

looks like this patch needs to be split. In part one you add the normal
CIRQ handling and enable_sdio_irq() callback while in part two you add
the workaround handling for the missing swakeup line.

Another thing, just to make things clearer, I would require a quirk flag
(not only passing the gpio number) to enable the remuxing of the DAT1
line. And yet another thing, it should be clear in the commit log that
for devices which actually provide the swakeup line, setting the wakeup
bit for the DAT lines should be sufficient. That would mean OMAP devices
need to provide the 'idle' pinctrl state.

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20130708/a06168d9/attachment.sig>