[PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init

Marc Zyngier marc.zyngier at arm.com
Tue Jan 22 05:25:55 EST 2013


On Mon, 21 Jan 2013 10:21:08 -0700, Stephen Warren <swarren at wwwdotorg.org>
wrote:
> On 01/20/2013 06:22 PM, Thomas Abraham wrote:
>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is
>> discoverable using call to clocksource_of_init.
> 
>> diff --git a/arch/arm/kernel/arch_timer.c
b/arch/arm/kernel/arch_timer.c
> 
>> +#ifdef CONFIG_CLKSRC_OF
>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer",
>> arch_timer_of_register)
>> +#endif
> 
> I wonder if we shouldn't enhance include/linux/clocksource.h to define
> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers
> wouldn't need that ifdef.

Indeed. That would be a lot nicer.

        M.
-- 
Fast, cheap, reliable. Pick two.


More information about the devicetree-discuss mailing list