[PATCH] ARM: architected timers: allow dt based discovery using clocksource_of_init

Thomas Abraham thomas.abraham at linaro.org
Tue Jan 22 05:30:47 EST 2013


Hi Stephen,

On 21 January 2013 09:21, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 01/20/2013 06:22 PM, Thomas Abraham wrote:
>> Add an entry in __clksrc_of_table so that ARMv7 architected timer is
>> discoverable using call to clocksource_of_init.
>
>> diff --git a/arch/arm/kernel/arch_timer.c b/arch/arm/kernel/arch_timer.c
>
>> +#ifdef CONFIG_CLKSRC_OF
>> +CLOCKSOURCE_OF_DECLARE(armv7_timer, "arm,armv7-timer", arch_timer_of_register)
>> +#endif
>
> I wonder if we shouldn't enhance include/linux/clocksource.h to define
> CLOCKSOURCE_OF_DECLARE even when !CONFIG_CLKSRC_OF; that way, drivers
> wouldn't need that ifdef.

Yes, it will be helpful to have a !CONFIG_CLKSRC_OF version of
CLOCKSOURCE_OF_DECLARE. And can CONFIG_CLKSRC_OF be enabled by default
for all ARM platforms?

Thanks,
Thomas.


More information about the devicetree-discuss mailing list