[PATCH 5/6] thermal:exynos4: Enable support for Exynos4412 SoCs

Sachin Kamat sachin.kamat at linaro.org
Mon Apr 22 16:40:06 EST 2013


On 22 April 2013 11:55, amit kachhap <amit.kachhap at gmail.com> wrote:
> Hi,
>
> I have one suggestion,
>
> On Fri, Apr 19, 2013 at 10:08 PM, Lukasz Majewski
> <l.majewski at samsung.com> wrote:
>> Enable TMU support for Exynos4412 based target with device tree.
>>
>> Signed-off-by: Lukasz Majewski <l.majewski at samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>> ---
>>  drivers/thermal/exynos_thermal.c |    4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/thermal/exynos_thermal.c b/drivers/thermal/exynos_thermal.c
>> index e922fa4..f54066d 100644
>> --- a/drivers/thermal/exynos_thermal.c
>> +++ b/drivers/thermal/exynos_thermal.c
>> @@ -819,6 +819,10 @@ static const struct of_device_id exynos_tmu_match[] = {
>>                 .data = (void *)EXYNOS4210_TMU_DRV_DATA,
>>         },
>>         {
>> +               .compatible = "samsung,exynos4412-tmu",
>> +               .data = (void *)EXYNOS_TMU_DRV_DATA,
>> +       },
> Instead of adding a new compatible string, "exynos5250-tmu" name can
> be re-used in the 4412 DT node file as 4412 and 5250 TMU controller
> are same.

In cases where they are the same, it was generally the previous
version of SoC that was added to the compatible list and re-used in
the higher ones. IIRC, in cases where exynos5 based string was already
defined a separate compatible string was added for exynos4 too (even
if they used same driver data).

-- 
With warm regards,
Sachin


More information about the devicetree-discuss mailing list