[PATCH] irqdomain: include linux/bug.h for WARN_ON()

Jamie Iles jamie at jamieiles.com
Fri Jan 13 01:41:26 EST 2012


On Thu, Jan 12, 2012 at 08:35:12AM -0600, Rob Herring wrote:
> Jamie,
> 
> On 12/19/2011 04:22 PM, Jamie Iles wrote:
> > Commit 6d274309d (irq: support domains with non-zero hwirq base)
> > introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
> > doesn't include linux/bug.h resulting in:
> > 
> > include/linux/irqdomain.h: In function 'irq_domain_to_irq':
> > include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
> > 
> > if it isn't implicitly pulled in before.
> > 
> 
> Considering major irqdomain changes are coming, is this really needed?
> Nothing is currently broken, right?

I think it's still worth applying though - if any of the new irqdomain 
work still uses WARN()/BUG() and friends then it'll be required, and it 
is possible that an existing platform with a different configuration 
_could_ run into this.

I'll leave it up to you though.

Jamie


More information about the devicetree-discuss mailing list