[PATCH] irqdomain: include linux/bug.h for WARN_ON()
Rob Herring
robherring2 at gmail.com
Fri Jan 13 01:35:12 EST 2012
Jamie,
On 12/19/2011 04:22 PM, Jamie Iles wrote:
> Commit 6d274309d (irq: support domains with non-zero hwirq base)
> introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
> doesn't include linux/bug.h resulting in:
>
> include/linux/irqdomain.h: In function 'irq_domain_to_irq':
> include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
>
> if it isn't implicitly pulled in before.
>
Considering major irqdomain changes are coming, is this really needed?
Nothing is currently broken, right?
Rob
> Cc: Rob Herring <rob.herring at calxeda.com>
> Cc: Grant Likely <grant.likely at secretlab.ca>
> Cc: Thomas Gleixner <tglx at linutronix.de>
> Signed-off-by: Jamie Iles <jamie at jamieiles.com>
> ---
> include/linux/irqdomain.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index fd9815b..0c17b4b 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -15,6 +15,7 @@
> #ifndef _LINUX_IRQDOMAIN_H
> #define _LINUX_IRQDOMAIN_H
>
> +#include <linux/bug.h>
> #include <linux/mod_devicetable.h>
>
> #ifdef CONFIG_IRQ_DOMAIN
More information about the devicetree-discuss
mailing list