[RESEND PATCH v3 3/7] Add utilfdt tests

Simon Glass sjg at chromium.org
Thu Sep 22 06:28:57 EST 2011


Hi David,

On Mon, Sep 19, 2011 at 6:11 PM, David Gibson
<david at gibson.dropbear.id.au> wrote:
> On Mon, Sep 19, 2011 at 01:21:04PM -0700, Simon Glass wrote:
>> This adds a few tests for the simple type argument supported by
>> utilfdt_decode_type.
>>
>> I assume this will be squashed in with utilfdt, but I have left it out
>> for easier review here.
>
> Yes, it should be squashed in.  Fwiw, in my experience, folding the
> tests in from day 1 does not significantly impair review, since the
> tests patch usually touches essentially disjoint files from the rest.

Well yes but it makes the commits big, and I've had to touch the
Makefile here again. Anyway, I have done this and will resend the
patch set.

Regards,
Simon

>
> --
> David Gibson                    | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
>                                | _way_ _around_!
> http://www.ozlabs.org/~dgibson
>


More information about the devicetree-discuss mailing list