[PATCH 2/3] ARM: Exynos4: Add ioremap interceptor for statically remapped regions

Grant Likely grant.likely at secretlab.ca
Thu Oct 13 14:29:31 EST 2011


On Wed, Oct 12, 2011 at 9:28 PM, Thomas Abraham
<thomas.abraham at linaro.org> wrote:
> On 12 October 2011 22:00, Thomas Abraham <thomas.abraham at linaro.org> wrote:
>> On 12 October 2011 21:43, Rob Herring <robherring2 at gmail.com> wrote:
>>> On 10/10/2011 03:11 AM, Thomas Abraham wrote:
>>>> ioremap() request for statically remapped regions are intercepted and the
>>>> statically assigned virtual address is returned. For requests for which
>>>> there are no statically remapped regions, the requests are let through.
>>>>
>>>> Cc: Kukjin Kim <kgene.kim at samsung.com>
>>>> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>
>>>> ---
>>>>  arch/arm/mach-exynos4/cpu.c             |   16 ++++++++++++++++
>>>>  arch/arm/mach-exynos4/include/mach/io.h |    4 ++++
>>>>  2 files changed, 20 insertions(+), 0 deletions(-)
>>>>
>>>
>>> You won't need this with Nico's vmalloc.h clean-up series. It does
>>> exactly this but generically for all platforms.
>>
>> Ok. Thanks for your suggestion. I will move to using Nico's patches.
>
> From Nico's reply to his pull request of vmalloc cleanup series, it
> looks like that pull request has been withdrawn (hope I am not missing
> anything here). Without Nico's series, and gic dt support for exynos4
> support requiring this patch, all other workarounds to replace this
> patch does not seem be correct.
>
> So is it acceptable to retain this patch and later rework/drop the
> exynos4 specific ioremap along with Nico's vmalloc patch series when
> it is merged.

I would say yes, but I don't get to make the decision here.

g.


More information about the devicetree-discuss mailing list