[PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.
Andrew Chew
AChew at nvidia.com
Thu Jul 21 08:52:55 EST 2011
> > + retval = of_property_read_u32(dn, "hssync_start_delay",
> > + (u32
> *)&phy_config->hssync_start_delay);
>
> Gah! Don't cast pointers that way. It will break badly if the sizes
> don't match. The variable *must* be a u32.
Can we have u16 and u8 versions of of_property_read, then? It'll simplify code. I'll be happy to submit a patch for that if that's what we want.
More information about the devicetree-discuss
mailing list