[PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

Linus Torvalds torvalds at linux-foundation.org
Sat Dec 3 09:41:06 EST 2011


On Fri, Dec 2, 2011 at 2:34 PM, Anton Vorontsov
<anton.vorontsov at linaro.org> wrote:
>
> One option is to test this patch on a board that is now broken:
>
> http://lkml.org/lkml/2011/11/10/290

That seems broken.

Spot the trouble:

  +	ret = irq_create_of_mapping(oirq.controller, oirq.specifier,
  +				    oirq.size);
  +no_irq:
  +#ifdef NO_IRQ
  +#if NO_IRQ != 0
  +	if (ret == NO_IRQ)
  +		pr_warn("Hit NO_IRQ case for your arch. Drivers might expect "
  +			"NO_IRQ, but we return 0. If anything breaks, driver "
  +			"have to be fixed.\n");
  +#endif
  +#endif
  +	return ret;

It claims "we return 0", but then doesn't return zero.. Hmm?

                  Linus


More information about the devicetree-discuss mailing list