[RFC v2 PATCH 2/3] dt: device tree bindings for TI's EMIF sdram controller

[Olof Johansson]

Hi,

Fewer comments here. :) But see below.

On Mon, Dec 19, 2011 at 6:05 AM, Aneesh V <aneesh at ti.com> wrote:


> --- /dev/null
> +++ b/Documentation/devicetree/bindings/memory-controllers/ti/emif.txt
> @@ -0,0 +1,64 @@
> +* EMIF family of TI SDRAM controllers
> +
> +EMIF - External Memory Interface - is an SDRAM controller used in
> +TI SoCs. EMIF supports, based on the IP revision, one or more of
> +DDR2/DDR3/LPDDR2 protocols. This binding describes a given instance
> +of the EMIF IP and memory parts attached to it.
> +
> +Required properties:
> +- compatible   : One or more of "ti,emif-ddr2", "ti,emif-ddr3", and
> +  "ti,emif-lpddr2"
> +
> +  "ti,emif-ddr2" should be listed of the EMIF controller on this SoC
> +  supports DDR2 memories
> +
> +  "ti,emif-ddr3" should be listed of the EMIF controller on this SoC
> +  supports DDR3 memories
> +
> +  "ti,emif-lpddr2" should be listed of the EMIF controller on this SoC
> +  supports LPDDR2 memories
> +
> +- ti,hwmods    : For TI hwmods processing and omap device creation
> +  the value shall be "emif<n>" where <n> is the number of the EMIF
> +  instance with base 1.
> +
> +- phy-type     : string indicating the phy type. Should be one of the
> +  following:
> +
> +  "phy-type-omap4"  : PHY used in OMAP4 family of SoCs
> +
> +  "phy-type-dm81xx" : PHY used in DM81XX family of SoCs
> +
> +- ddr-handle   : phandle to a "ddr" node representing the memory part
> +  attached to this EMIF instance.

Just specify said ddr node as a child of this node instead of give it
a handle. What other bus would the ddr node sit on, if not the memory
controller bus?



-Olof