[PATCH v3 0/4] OMAP serial device tree support

Rob Herring robherring2 at gmail.com
Sat Dec 17 09:02:05 EST 2011


Tony,

On 12/16/2011 03:57 PM, Tony Lindgren wrote:
> Rob,
> 
> * Rob Herring <robherring2 at gmail.com> [111214 05:16]:
>> On 12/14/2011 05:55 AM, Rajendra Nayak wrote:
>>> v3 is rebased on top of the latest serial runtime
>>> patches[1] and boot tested with/without DT on OMAP4
>>> SDP and OMAP4 Panda boards.
>>>
>>> Patches can be found here..
>>> git://gitorious.org/omap-pm/linux.git for-dt/serial
>>>
>>> I also had to pull in a fix[2] for DT testing (already in linux-omap
>>> master) which was missing as the serial runtime branch[1]
>>> was based on an older master commit.
>>>
>>> Changes in v3:
>>> -1- Rebased on latest serial runtime patches
>>> -2- Minor typr fixes
>>>
>>> Changes in v2:
>>> -1- Got rid of binding to define which uart is console
>>> -2- Added checks to default clock speed to 48Mhz
>>> -3- Added compatible for each OMAP family
>>> -4- Used of_alias_get_id to populate port.line
>>>
>>> [1] git://gitorious.org/runtime_3-0/runtime_3-0.git for_3_3/lo_rc4_uartruntime
>>> [2] http://www.spinics.net/lists/arm-kernel/msg150751.html
>>>
>>> Rajendra Nayak (4):
>>>   omap-serial: Get rid of all pdev->id usage
>>>   omap-serial: Use default clock speed (48Mhz) if not specified
>>>   omap-serial: Add minimal device tree support
>>>   ARM: omap: pass minimal SoC/board data for UART from dt
>>>
>>>  .../devicetree/bindings/serial/omap_serial.txt     |   10 +++
>>>  arch/arm/boot/dts/omap3.dtsi                       |   31 ++++++++
>>>  arch/arm/boot/dts/omap4.dtsi                       |   28 +++++++
>>>  arch/arm/mach-omap2/board-generic.c                |    1 -
>>>  drivers/tty/serial/omap-serial.c                   |   80 +++++++++++++++----
>>>  5 files changed, 132 insertions(+), 18 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/serial/omap_serial.txt
>>
>> Looks good. For the series:
>>
>> Reviewed-by: Rob Herring <rob.herring at calxeda.com>
> 
> Care to check if your Reviewed-by can also be applied
> to the additional patch "[PATCH] arm/dts: Add minimal device
> tree support for omap2420 and omap2430" that's needed
> to keep serial port working for omap2 with this series?

It looks fine.

Rob


More information about the devicetree-discuss mailing list