Mistake in p2020rdb.dts?

Scott Wood scottwood at freescale.com
Wed Apr 20 02:04:22 EST 2011


On Tue, 19 Apr 2011 00:12:59 -0700
<jobhunts02 at aol.com> wrote:

> I am running Linux 2.6.32 on a P2020 and am trying to use the kernel’s DMA code. So far, I have had no success.  Is there a mistake in linux/arch/powerc/boot/dts/p2020rdb.dts?
>  
> According to linux/Documentation/powerpc/dts-bindings/fsl/dma.txt, the compatible lists for DMA controllers and the DMA channel nodes should have “2 entries, first is ‘fsl,CHIP-dma’, where CHIP is the processor (mpc8349, mpc8360, etc.) and the second is ‘fsl,elo-dma.’”  In p2020rdb.dts, the compatible lists for the DMA controller and the DMA channel nodes are "fsl,eloplus-dma" and "fsl,eloplus-dma-channel," respectively.  Note that each has only one entry.
>  
> Should compatible = “fsl,P2020RDB-dma”, "fsl,eloplus-dma"  for the DMA controllers?, and
> Should compatible = “fsl,P2020RDB-dma”, " fsl,eloplus-dma-channel"  for the DMA channel nodes?

P2020RDB is not a chip, it's a board.  Plus, we usually use lowercase for
this.

compatible should be "fsl,p2020-dma", "fsl,eloplus-dma", and likewise for
the channels.

-Scott



More information about the devicetree-discuss mailing list