Mistake in p2020rdb.dts?

[jobhunts02 at aol.com]

I am running Linux 2.6.32 on a P2020 and am trying to use the kernel’s DMA code. So far, I have had no success.  Is there a mistake in linux/arch/powerc/boot/dts/p2020rdb.dts?
 
According to linux/Documentation/powerpc/dts-bindings/fsl/dma.txt, the compatible lists for DMA controllers and the DMA channel nodes should have “2 entries, first is ‘fsl,CHIP-dma’, where CHIP is the processor (mpc8349, mpc8360, etc.) and the second is ‘fsl,elo-dma.’”  In p2020rdb.dts, the compatible lists for the DMA controller and the DMA channel nodes are "fsl,eloplus-dma" and "fsl,eloplus-dma-channel," respectively.  Note that each has only one entry.
 
Should compatible = “fsl,P2020RDB-dma”, "fsl,eloplus-dma"  for the DMA controllers?, and
Should compatible = “fsl,P2020RDB-dma”, " fsl,eloplus-dma-channel"  for the DMA channel nodes?
 
The device tree source for DMA in p2020rdb.dts is:
 
            dma at c300 {
                  #address-cells = <1>;
                  #size-cells = <1>;
                  compatible = "fsl,eloplus-dma";
                  reg = <0xc300 0x4>;
                  ranges = <0x0 0xc100 0x200>;
                  cell-index = <1>;
                  dma-channel at 0 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x0 0x80>;
                        cell-index = <0>;
                        interrupt-parent = <&mpic>;
                        interrupts = <76 2>;
                  };
                  dma-channel at 80 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x80 0x80>;
                        cell-index = <1>;
                        interrupt-parent = <&mpic>;
                        interrupts = <77 2>;
                  };
                  dma-channel at 100 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x100 0x80>;
                        cell-index = <2>;
                        interrupt-parent = <&mpic>;
                        interrupts = <78 2>;
                  };
                  dma-channel at 180 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x180 0x80>;
                        cell-index = <3>;
                        interrupt-parent = <&mpic>;
                        interrupts = <79 2>;
                  };
            };
 
 
            dma at 21300 {
                  #address-cells = <1>;
                  #size-cells = <1>;
                  compatible = "fsl,eloplus-dma";
                  reg = <0x21300 0x4>;
                  ranges = <0x0 0x21100 0x200>;
                  cell-index = <0>;
                  dma-channel at 0 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x0 0x80>;
                        cell-index = <0>;
                        interrupt-parent = <&mpic>;
                        interrupts = <20 2>;
                  };
                  dma-channel at 80 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x80 0x80>;
                        cell-index = <1>;
                        interrupt-parent = <&mpic>;
                        interrupts = <21 2>;
                  };
                  dma-channel at 100 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x100 0x80>;
                        cell-index = <2>;
                        interrupt-parent = <&mpic>;
                        interrupts = <22 2>;
                  };
                  dma-channel at 180 {
                        compatible = "fsl,eloplus-dma-channel";
                        reg = <0x180 0x80>;
                        cell-index = <3>;
                        interrupt-parent = <&mpic>;
                        interrupts = <23 2>;
                  };
            };
 
 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/devicetree-discuss/attachments/20110419/1711f8e9/attachment-0001.html>