[PATCH 5/5] of/irq: merge of_irq_map_one()

Grant Likely grant.likely at secretlab.ca
Fri Jun 18 09:11:02 EST 2010


On Thu, Jun 10, 2010 at 7:17 PM, Benjamin Herrenschmidt
<benh at kernel.crashing.org> wrote:
> On Thu, 2010-06-10 at 17:36 -0600, Grant Likely wrote:
>>
>> Okay.  I had been trying to avoid #ifdefs in the common code, but
>> you're probably right.  I'll rework.
>
> Not even ifdef's ... just move the quirk map there. You can always
> #define the quirk variable to 0 on archs that have no quirks, to
> make it compile away if you believe it represents bloat, but they
> are simple well localized things so I doubt it matters.

They're pretty small, but powermac32 is the only code that actually
uses the quirk facility.  Everything else parses sanely it would
appear.  I'd rather have them localized to the powermac code and
eliminate the quirks from the common code.

If other platforms show up with bad irq mappings, then I want to take
the approach of fixing the data rather than adding more quirks cases.

Anyway, let me try my hand at reworking to be a lot clearer and see
what it looks like.

g.


More information about the devicetree-discuss mailing list