[PATCH 9/9 V3] Test constant expressions in cell contexts.

Jon Loeliger jdl at freescale.com
Wed Oct 1 01:46:48 EST 2008


On Tue, 2008-09-30 at 16:04 +1000, David Gibson wrote:
> On Fri, Sep 26, 2008 at 03:25:48PM -0500, Jon Loeliger wrote:
> > From: Jon Loeliger <jdl at freescale.com>
> > 
> > This code is derived from code posted by David Gibson.
> 
> [snip]
> > +		for (i = 0; i < ARRAY_SIZE(expr_table); i++)
> > +			if (fdt32_to_cpu(res[i]) != expr_table[i].result)
> 
> Hrm.. when you fixed the endian bug here (I found it myself the other
> day), you might have thought to fix it...
> 
> 
> > +				FAIL("Incorrect result for expression \"%s\","
> > +				     " 0x%x instead of 0x%x\n",
> > +				     expr_table[i].expr, res[i],
>                                                          ^^^^^^
> 
> ...here, too.


Gah.  Sorry.  I'll definitely pick that up.

jdl





More information about the devicetree-discuss mailing list