[ccan] [PATCH 0/5] darray: fixes & additions

Cody P Schafer dev at codyps.com
Mon Aug 17 11:50:12 AEST 2015


Ya, you know what: the "darray: add darray_char sprintf work-alike
(and some helpers)" was first previously, but I just reordered it
because it didn't seem to make logical sense there.

I can resend with the order fixed, but I'll wait to see if any other
comments crop up.

On Sun, Aug 16, 2015 at 8:12 PM, Andy Grover <agrover at redhat.com> wrote:
> On 08/16/2015 04:22 PM, Cody P Schafer wrote:
>>
>> I think I've sent this out before and perhaps didn't get a response from
>> the module owner?
>> Figured I'd send it again as I'm still carrying these locally.
>>
>> Cody P Schafer (5):
>>    darray: don't include ourselves in _info
>>    darray: test: only use darray_make_room() if we HAVE_STATEMENT_EXPR
>>    darray: test: use the public darray_reset()
>>    darray: include config.h first
>>    darray: add darray_char sprintf work-alike (and some helpers)
>>
>>   ccan/darray/_info      |  2 --
>>   ccan/darray/darray.h   | 37 +++++++++++++++++++++++++++++++++----
>>   ccan/darray/test/run.c | 27 +++++++++++++++------------
>>   3 files changed, 48 insertions(+), 18 deletions(-)
>>
>
> darray_reset is used in patch 3 but only defined in patch 5. Could you move
> its definition up to patch 3?
>
> Thanks -- Andy
>


More information about the ccan mailing list