[ccan] [PATCH 0/5] darray: fixes & additions

Andy Grover agrover at redhat.com
Mon Aug 17 10:12:43 AEST 2015


On 08/16/2015 04:22 PM, Cody P Schafer wrote:
> I think I've sent this out before and perhaps didn't get a response from the module owner?
> Figured I'd send it again as I'm still carrying these locally.
>
> Cody P Schafer (5):
>    darray: don't include ourselves in _info
>    darray: test: only use darray_make_room() if we HAVE_STATEMENT_EXPR
>    darray: test: use the public darray_reset()
>    darray: include config.h first
>    darray: add darray_char sprintf work-alike (and some helpers)
>
>   ccan/darray/_info      |  2 --
>   ccan/darray/darray.h   | 37 +++++++++++++++++++++++++++++++++----
>   ccan/darray/test/run.c | 27 +++++++++++++++------------
>   3 files changed, 48 insertions(+), 18 deletions(-)
>

darray_reset is used in patch 3 but only defined in patch 5. Could you 
move its definition up to patch 3?

Thanks -- Andy



More information about the ccan mailing list