[ccan] [PATCH v3 2/2] maskn & bitops: add new modules

Rusty Russell rusty at rustcorp.com.au
Wed Jul 30 17:09:00 EST 2014


Rusty Russell <rusty at rustcorp.com.au> writes:
> Cody P Schafer <dev at codyps.com> writes:
>> 'maskn' provides generation of n-bit masks from a given range.
>> 'bitops' provides some generic bit operations that maskn needs.
>>
>> Both operate on 32-bit values only (that's just what I needed at this
>> point).
>>
>> There is some overlap between ilog and bitops that would
>> be good to remove (fls).
>>
>> Signed-off-by: Cody P Schafer <dev at codyps.com>
>
> Thanks, applied.

Unapplied.  It fails to link a trivial program here, because
gcc in default mode complains about two copies of all those inline
functions.  -stc=c99 works.

We'd need a HAVE_STATIC_INLINES I think, but configurator is going to
have to get smarter to detect it.

Personally, I'd either use static inline in the headers, or skip inline
at all.  Those who care should be using magic linkers...

Cheers,
Rusty.


More information about the ccan mailing list