[ccan] base64 implementation - feedback requested

[Peter Barker]

I would appreciate some feedback on a base64 implementation for ccan.

The first branch is an adjustment to ccan/tap; is_str and is_mem 
implementations giving perl-style, 'expected "foo", got "bar"' errors.


The following changes since commit 
8b0bdb090e2882aa431e89f4bc7aa4736e9e2838:

   structeq: new module. (2014-06-25 15:53:34 +0930)

are available in the git repository at:

   https://github.com/peterbarker/ccan.git tap-is_foo-defines

for you to fetch changes up to 6a4e2f3de7e6fb8b0438add710477a93a0de355f:

   remove is_num as too ambitious got the time being (format string 
problems in output); add description for is_mem (2014-07-11 19:59:52 
+1000)

----------------------------------------------------------------
Peter Barker (2):
       add is_num, is_mem and is_str
       remove is_num as too ambitious got the time being (format string 
problems in output); add description for is_mem

  ccan/tap/tap.h | 34 ++++++++++++++++++++++++++++++++++
  1 file changed, 34 insertions(+)




The second branch (pulling from the first) is the base64 implementation:


The following changes since commit 
8b0bdb090e2882aa431e89f4bc7aa4736e9e2838:

   structeq: new module. (2014-06-25 15:53:34 +0930)

are available in the git repository at:

   https://github.com/peterbarker/ccan.git base64

for you to fetch changes up to 10211ae1ab3d2152853a530a1e3b7a59c9f77655:

   apparently api.c is an important filename...; move compiler warnings 
around; put in is_int and is_size_t from tap.h; bits and pieces to make 
ccan happy (2014-07-11 20:32:34 +1000)

----------------------------------------------------------------
Peter Barker (6):
       add is_num, is_mem and is_str
       initial base64 commit
       The base64 tests use is_str, is_mem and is_num
       remove is_num as too ambitious got the time being (format string 
problems in output); add description for is_mem
       Pull in warning fixes for is_str and is_mem
       apparently api.c is an important filename...; move compiler warnings 
around; put in is_int and is_size_t from tap.h; bits and pieces to make 
ccan happy

  Makefile-ccan          |   1 +
  ccan/base64/GPL-2      |   1 +
  ccan/base64/LICENSE    |   1 +
  ccan/base64/_info      |  46 +++++++++++++
  ccan/base64/base64.c   | 183 
+++++++++++++++++++++++++++++++++++++++++++++++++
  ccan/base64/base64.h   |  44 ++++++++++++
  ccan/base64/test/api.c | 110 +++++++++++++++++++++++++++++
  ccan/tap/tap.h         |  34 +++++++++
  8 files changed, 420 insertions(+)
  create mode 120000 ccan/base64/GPL-2
  create mode 120000 ccan/base64/LICENSE
  create mode 100644 ccan/base64/_info
  create mode 100644 ccan/base64/base64.c
  create mode 100644 ccan/base64/base64.h
  create mode 100644 ccan/base64/test/api.c


If this is entirely the wrong way about getting this code into ccan - 
please let me know the *right* way to do things :-)


Thanks,
-- 
Peter Barker                          |   Programmer,Sysadmin,Geek.
pbarker at barker.dropbear.id.au	      |   You need a bigger hammer.
:: It's a hack! Expect underscores! - Nigel Williams