[ccan] [patches] Minor ccanlint changes

Rusty Russell rusty at rustcorp.com.au
Sat Jan 22 13:02:27 EST 2011


On Fri, 21 Jan 2011 04:17:05 am Brad Hards wrote:
> 0002 is worth looking at first.  It protects the new examples_relevant test 
> against a function description that doesn't actually have the proper format 
> summary line (e.g. is missing the "my_foo -" part).

Thanks, applied.  Good catch!

> 
> The other two I'm not so sure about. The layout looks a bit strange without 
> them, but perhaps there is a cleaner way to handle this (like always appending 
> the newline if not already present)

I was in two minds too, but I found a few others.  So I chose to make it
automagic like you suggested:

		if (score->error) {
			printf("%s%s", score->error,
			       strends(score->error, "\n") ? "" : "\n");
		}

Thanks!
Rusty.


More information about the ccan mailing list