[Cbe-oss-dev] [PATCH 2/2]MARS: fix dma list element initialization

Kazunori Asayama asayama at sm.sony.co.jp
Wed Sep 10 11:55:48 EST 2008


Yuji Mano wrote:
> This fixes a critical bug where the notify and reserved structure members of
> the dma list element are not properly initialized, causing random stalls after
> the dma completion.
> 
> Signed-off-by: Yuji Mano <yuji.mano at am.sony.com>

Acked-by: Kazunori Asayama <asayama at sm.sony.co.jp>

> 
> ---
>  include/mpu/mars/mars_dma.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> --- a/include/mpu/mars/mars_dma.h
> +++ b/include/mpu/mars/mars_dma.h
> @@ -67,6 +67,8 @@ static inline unsigned int _list_init(mf
>  		unsigned int block_size;
>  		block_size = (size < MARS_DMA_SIZE_MAX) ?
>  				size : MARS_DMA_SIZE_MAX;
> +		list[count].notify = 0;
> +		list[count].reserved = 0;
>  		list[count].size = block_size;
>  		list[count].eal = eal;
>  		size -= block_size;
> 
> 
> 

-- 
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t



More information about the cbe-oss-dev mailing list