[Cbe-oss-dev] [PATCH 8/10 v2] MARS: workload queue mutex protection

[Kazunori Asayama]

Geoff Levand wrote:
> On 08/29/2008 06:26 PM, Yuji Mano wrote:
>> -	MARS_CHECK_RET(*id < MARS_WORKLOAD_MAX, MARS_ERROR_LIMIT);
>> +	MARS_CHECK_CLEANUP_RET(queue->block[block].bits[index].state ==
>> +		MARS_WORKLOAD_STATE_NONE,
>> +		mars_mutex_unlock((struct mars_mutex *)&queue->block[block]),
>> +		MARS_ERROR_STATE);
> 
> As I said in another mail, these macros cannot be traced and will make
> it very hard to find bugs, and so should be removed.

Mano-san plans to eliminate those macros by upcoming another patch.
Please wait for that?

-- 
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t