[Cbe-oss-dev] [PATCH 8/10 v2] MARS: workload queue mutex protection

Geoff Levand geoffrey.levand at am.sony.com
Mon Sep 1 05:13:35 EST 2008


On 08/29/2008 06:26 PM, Yuji Mano wrote:
> -	MARS_CHECK_RET(*id < MARS_WORKLOAD_MAX, MARS_ERROR_LIMIT);
> +	MARS_CHECK_CLEANUP_RET(queue->block[block].bits[index].state ==
> +		MARS_WORKLOAD_STATE_NONE,
> +		mars_mutex_unlock((struct mars_mutex *)&queue->block[block]),
> +		MARS_ERROR_STATE);

As I said in another mail, these macros cannot be traced and will make
it very hard to find bugs, and so should be removed.




More information about the cbe-oss-dev mailing list