[Cbe-oss-dev] [PATCH 02/10]MARS: Rename variable names for consistency

[Kazunori Asayama]

Geert Uytterhoeven wrote:
> On Thu, 2 Oct 2008, Yuji Mano wrote:
>> This renames some variables for consistency, to add the _ea suffix to all
>> variables that are effective addresses.
> 
>> --- a/include/common/mars/mars_task_types.h
>> +++ b/include/common/mars/mars_task_types.h
>> @@ -150,14 +150,14 @@ struct mars_task_id {
>>  struct mars_task_context {
>>  	struct mars_task_id id;		/* task id */
>>  	struct mars_task_args args;	/* task args */
>> -	uint64_t exec;			/* ea of exec */
>> +	uint64_t exec_ea;		/* ea of exec */
> 
> Would it make sense to create a specific typedef for effective addresses?
> Then we can annotate the typedef for running sparse, cfr. __iomem in the
> kernel.

I once considered the same thing... but effective address can be
passed/shared between host and MPU via mailboxes, cache line, etc, so in
some cases it's needed that MARS developers and/or application
programmers know its explicit size.

-- 
(ASAYAMA Kazunori
  (asayama at sm.sony.co.jp))
t