[Cbe-oss-dev] [PATCH 02/10]MARS: Rename variable names for consistency

Geert Uytterhoeven Geert.Uytterhoeven at sonycom.com
Fri Oct 3 18:11:18 EST 2008


On Thu, 2 Oct 2008, Yuji Mano wrote:
> This renames some variables for consistency, to add the _ea suffix to all
> variables that are effective addresses.

> --- a/include/common/mars/mars_task_types.h
> +++ b/include/common/mars/mars_task_types.h
> @@ -150,14 +150,14 @@ struct mars_task_id {
>  struct mars_task_context {
>  	struct mars_task_id id;		/* task id */
>  	struct mars_task_args args;	/* task args */
> -	uint64_t exec;			/* ea of exec */
> +	uint64_t exec_ea;		/* ea of exec */

Would it make sense to create a specific typedef for effective addresses?
Then we can annotate the typedef for running sparse, cfr. __iomem in the
kernel.

With kind regards,

Geert Uytterhoeven
Software Architect

Sony Techsoft Centre Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium

Phone:    +32 (0)2 700 8453
Fax:      +32 (0)2 700 8622
E-mail:   Geert.Uytterhoeven at sonycom.com
Internet: http://www.sony-europe.com/

A division of Sony Europe (Belgium) N.V.
VAT BE 0413.825.160 · RPR Brussels
Fortis · BIC GEBABEBB · IBAN BE41293037680010


More information about the cbe-oss-dev mailing list