[Cbe-oss-dev] [RFC] [PATCH 3:8] SPU Gang Scheduling - Change cbe_spu_info[] mutex to spin lock

[Luke Browning]

On Tue, 2008-03-11 at 21:47 +0100, Christoph Hellwig wrote:
> The general idea of changing the list_mutex to a spinlock is fine with
> me.  I'm a little concerned about moving spu_{,un}bind_context out
> of the critical section.  I moved them into it specificly to protect
> against races where we check if a context is loaded or not.  Now we're
> moving the manipulation of ->ctx out of these helper so they're still
> inside the critical section.  This really needs a bit of an audit for
> places that use ->ctx != NULL as an equivalent for the runnable check.

It is not really different.  You need the context lock to make either
check.  Same as before.  

Luke