[Cbe-oss-dev] [RFC] [PATCH 3:8] SPU Gang Scheduling - Change cbe_spu_info[] mutex to spin lock

Christoph Hellwig hch at lst.de
Wed Mar 12 07:47:43 EST 2008


The general idea of changing the list_mutex to a spinlock is fine with
me.  I'm a little concerned about moving spu_{,un}bind_context out
of the critical section.  I moved them into it specificly to protect
against races where we check if a context is loaded or not.  Now we're
moving the manipulation of ->ctx out of these helper so they're still
inside the critical section.  This really needs a bit of an audit for
places that use ->ctx != NULL as an equivalent for the runnable check.




More information about the cbe-oss-dev mailing list