[Cbe-oss-dev] [PATCH]libspe2: make spe_context_create_affinity spec conform

[Dirk Herrendoerfer]

Exactly - I got this confused with the gang parameter which should
not be NULL - I'll resend.

Sorry for the confusion !.

Mit freundlichen Grüßen / Kind regards

Dirk Herrendoerfer

Software Developer / libspe Maintainer
IBM Systems &Technology Group, Systems Software Development / SW Linux on
Cell BE Development & Evaluation
-------------------------------------------------------------------------------------------------------------------------------------------

IBM Deutschland
Schoenaicher Str. 220
71032 Boeblingen
Phone: +49-7031-16-3642
Mobile: +49-172 7240378
E-Mail: d.herrendoerfer at de.ibm.com
-------------------------------------------------------------------------------------------------------------------------------------------

IBM Deutschland Research & Development GmbH / Vorsitzender des
Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart,
HRB 243294


cbe-oss-dev-bounces+d.herrendoerfer=de.ibm.com at ozlabs.org wrote on
27.08.2008 04:21:47:

> Dirk Herrendoerfer wrote:
> > According to spec the spe_context_create_affinity() call should
> > not accept NULL as an argument to affinity_neighbor.
> > This fixes it.
> >
> > Ok to apply ?
>
> No. The spec says "A NULL value may be specified for the initial SPE
> context.", so NULL value must be allowed as affinity_neighbor. Did you
> mistake it for the 'gang' parameter?
>
> >
> > Signed-off-by: D. Herrendoerfer <d_herrendoerfer at herrendoerfer dot
name >
> >
> > Index: libspe2/libspe2.c
> > ===================================================================
> > --- libspe2/libspe2.c   (revision 129)
> > +++ libspe2/libspe2.c   (working copy)
> > @@ -60,6 +60,9 @@ spe_context_ptr_t spe_context_create(uns
> >   */
> >  spe_context_ptr_t spe_context_create_affinity(unsigned int flags,
> spe_context_ptr_t affinity_neighbor, spe_gang_context_ptr_t gang)
> >  {
> > +   if ( affinity_neighbor == NULL ) {
> > +      return NULL;
> > +   }
> >     spe_context_ptr_t spe = _base_spe_context_create(flags, gang,
> affinity_neighbor);
> >     if ( spe == NULL ) {
> >        return NULL;
> >
> >
> > _______________________________________________
> > cbe-oss-dev mailing list
> > cbe-oss-dev at ozlabs.org
> > https://ozlabs.org/mailman/listinfo/cbe-oss-dev
> >
> >
> >
>
>
> --
> (ASAYAMA Kazunori
>    (asayama at sm.sony.co.jp))
> t
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev