[Cbe-oss-dev] [PATCH]libspe2: make spe_context_create_affinity spec conform

[Kazunori Asayama]

Dirk Herrendoerfer wrote:
> According to spec the spe_context_create_affinity() call should
> not accept NULL as an argument to affinity_neighbor.
> This fixes it.
> 
> Ok to apply ?

No. The spec says "A NULL value may be specified for the initial SPE 
context.", so NULL value must be allowed as affinity_neighbor. Did you 
mistake it for the 'gang' parameter?

> 
> Signed-off-by: D. Herrendoerfer <d_herrendoerfer at herrendoerfer dot name >
> 
> Index: libspe2/libspe2.c
> ===================================================================
> --- libspe2/libspe2.c	(revision 129)
> +++ libspe2/libspe2.c	(working copy)
> @@ -60,6 +60,9 @@ spe_context_ptr_t spe_context_create(uns
>   */
>  spe_context_ptr_t spe_context_create_affinity(unsigned int flags, spe_context_ptr_t affinity_neighbor, spe_gang_context_ptr_t gang)
>  {
> +	if ( affinity_neighbor == NULL ) {
> +		return NULL;
> +	}
>  	spe_context_ptr_t spe = _base_spe_context_create(flags, gang, affinity_neighbor);
>  	if ( spe == NULL ) {
>  		return NULL;
> 
> 
> _______________________________________________
> cbe-oss-dev mailing list
> cbe-oss-dev at ozlabs.org
> https://ozlabs.org/mailman/listinfo/cbe-oss-dev
> 
> 
> 


-- 
(ASAYAMA Kazunori
   (asayama at sm.sony.co.jp))
t