[Cbe-oss-dev] [patch 1/4] MARS: Header file cleanups

Andrew Pinski pinskia at gmail.com
Mon Aug 25 12:23:39 EST 2008


On Sun, Aug 24, 2008 at 7:18 PM, Kazunori Asayama <asayama at sm.sony.co.jp> wrote:
> Geoff Levand wrote:
>>
>> Cleanup header files:
>
> (snip)
>>
>>  o Use system include path for installed headers.
>
> Why is that needed? Many software, such as OpenGL, OpenSSL, X11 and more,
> follow the same way as the current MARS's one. IMO, it's better to  create a
> sub directory for MARS headers rather than to put many random MARS headers
> in the system include directory directly.
>
>>  o Remove hard-coded include path.
>
> Which is 'hard-coded'? I guess 'hard-coded' means 'mars/*.h', but I don't
> think it is 'hard-coded'. I understand it is just *relative* to
> include paths.


If we are going to keep mars/*.h then it would be best to remove mars_
part of the headers though.

When dealing with installed headers, I rather have them installed in a
separate directory than just in the normal include directory.  This
makes it easier to do a search for a function.

-- Pinski

Thanks,
Andrew Pinski



More information about the cbe-oss-dev mailing list