[Cbe-oss-dev] [PATCH 2/8] spufs: Trace spufs_stop_callback events

[Julio M. Merino Vidal]

On Fri, Apr 25, 2008 at 02:10:33PM +0200, Christoph Hellwig wrote:
> On Fri, Apr 25, 2008 at 12:07:23PM +0200, jmerino at ac.upc.edu wrote:
> > The spuevent module contained a trace entry for spufs_stop_callback,
> 
> What's spuevent?

Oops, should read sputrace.  Fixed.

> 
> > +#if 0
> > +	/* XXX This fires in interrupt context and we need to take a lock to
> > +	 * log the event... so, it's a no-no. */
> >  	{ "spufs_stop_callback__enter", "ctx %p spu %p", spu_context_event },
> > +#endif
> 
> Adding a marker that's not actually used is not quite helpful.

The marker *CAN* be safely used with SystemTap, for example (and I'm already
using it).  If it doesn't work with sputrace... that's another story, and
it is why I'm adding a note in the code mentioning why it is there but does
not work.

-- 
Julio M. Merino Vidal <jmerino at ac.upc.edu>