[Cbe-oss-dev] [PATCH 2/8] spufs: Trace spufs_stop_callback events

[Christoph Hellwig]

On Fri, Apr 25, 2008 at 12:07:23PM +0200, jmerino at ac.upc.edu wrote:
> The spuevent module contained a trace entry for spufs_stop_callback,

What's spuevent?

> Signed-off-by: Julio M. Merino Vidal <jmerino at ac.upc.edu>
> Index: linux-2.6.25.y/arch/powerpc/platforms/cell/spufs/run.c
> ===================================================================
> --- linux-2.6.25.y.orig/arch/powerpc/platforms/cell/spufs/run.c
> +++ linux-2.6.25.y/arch/powerpc/platforms/cell/spufs/run.c
> @@ -15,6 +15,8 @@ void spufs_stop_callback(struct spu *spu
>  {
>  	struct spu_context *ctx = spu->ctx;
>  
> +	spu_context_trace(spufs_stop_callback__enter, ctx, spu);
> +

> +#if 0
> +	/* XXX This fires in interrupt context and we need to take a lock to
> +	 * log the event... so, it's a no-no. */
>  	{ "spufs_stop_callback__enter", "ctx %p spu %p", spu_context_event },
> +#endif

Adding a marker that's not actually used is not quite helpful.