[Cbe-oss-dev] [PATCH 2.6.23] PS3: Ignore storage devices that are still being probed

[Geert Uytterhoeven]

On Fri, 7 Sep 2007, Michael Ellerman wrote:
> On Fri, 2007-09-07 at 11:43 +0200, Geert Uytterhoeven wrote:
> > On Fri, 7 Sep 2007, Michael Ellerman wrote:
> > > On Fri, 2007-09-07 at 01:49 -0700, Geoff Levand wrote:
> > > > Geert Uytterhoeven wrote:
> > > > > PS3: A storage device may show up in the repository before the hypervisor has
> > > > > finished probing:
> > > > >   - If its type is not yet known, it shows up as PS3_DEV_TYPE_STOR_DUMMY,
> > > > >   - If its regions are being probed, it shows up as having zero regions.
> > > > > If any of these happen, consider the device not yet present.  The storage
> > > > > probe thread will retry later.
> > > > > 
> > > > > This fixes the timing-dependent problem where a kernel booted from FLASH ROM
> > > > > sometimes cannot find the hard disk.
> > > > > 
> > > > > Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven at sonycom.com>
> > > > 
> > > > Paul,
> > > > 
> > > > This fixes a problem reported by users, so it would be nice for it to go
> > > > in for 2.6.23 if possible.  Sorry for it being so late. 
> > > 
> > > Does it only happen when booting from flash? If so why? I'm seeing the
> > > same symptom (hard disk not showing up), but booting from kboot.
> > 
> > So far we've seen it ourselves when booting from flash only. That doesn't
> > necessarily mean it cannot happen when booting from kboot.
> > 
> > It depends a lot on timing: firmware version, hard disk model, kernel config,
> > cold or warm boot, ... That's why it was so hard to track down.
> 
> OK. We've been cold booting into kboot and pretty quickly booting the
> 2nd kernel, so I guess it's possible we're hitting this.
> 
> > Does the patch fix the problem for you?
> 
> We haven't tried, will have to give it a go on Monday.
> 
> > What kernel are you using the first place?
> 
> -rc5 or thereabouts.

Plain -rc5 or Geoff's git tree (or his patches on top of -rc5)?

With kind regards,
 
Geert Uytterhoeven
Software Architect

Sony Network and Software Technology Center Europe
The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium
 
Phone:    +32 (0)2 700 8453	
Fax:      +32 (0)2 700 8622	
E-mail:   Geert.Uytterhoeven at sonycom.com	
Internet: http://www.sony-europe.com/
 	
Sony Network and Software Technology Center Europe	
A division of Sony Service Centre (Europe) N.V.	
Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium	
VAT BE 0413.825.160 · RPR Brussels	
Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619